Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated API for the type ReadonlyArray<string> #1099

Closed
AndrewJakubowicz opened this issue May 4, 2023 · 0 comments · Fixed by #1102
Closed

Fix generated API for the type ReadonlyArray<string> #1099

AndrewJakubowicz opened this issue May 4, 2023 · 0 comments · Fixed by #1102

Comments

@AndrewJakubowicz
Copy link
Contributor

On https://lit.dev/docs/api/custom-directives/#AttributePart the strings property with type ReadonlyArray<string> ends up a TODO.

See
Screenshot 2023-05-04 at 4 47 48 PM

A hacky fix was introduced in #1098 but this needs to be resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Lit Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hacks introduced yesterday to remove generated TODOs lit/lit.dev
1 participant
@AndrewJakubowicz