Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added esbuild plugin to support typescript for local dev and playwright test #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: added esbuild plugin to support typescript for local dev and playwright test #88

wants to merge 1 commit into from

Conversation

hsuehic
Copy link

@hsuehic hsuehic commented Mar 20, 2023 •
edited
Loading

To dev locally without a compiling process, just using the web dev server to do the transform.

<!DOCTYPE html>

<html>
  <head>
    <meta charset="utf-8" />
    <title>&lt;my-element> Demo</title>
    <script type="module" src="../src/my-element.ts"></script>
    <style>
      p {
        border: solid 1px blue;
        padding: 8px;
      }
    </style>
  </head>
  <body>
    <my-element>
      <p>This is child content</p>
    </my-element>
  </body>
</html>

Encountered issue (Chrome devtool console) the following issue, when running

npm run serve

image

I added esbuild plugin to solve the issue.

@google-cla
Copy link

google-cla bot commented Mar 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsuehic hsuehic force-pushed the main branch 2 times, most recently from 0cfdffe to 2053ff1 Compare March 21, 2023 10:09
polRk
polRk reviewed Nov 1, 2023
View reviewed changes
web-dev-server.config.js
jsx: true,
ts: true,
tsx: true,
jsxFactory: 'React.createElement',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react ?

polRk
polRk reviewed Nov 1, 2023
View reviewed changes
web-dev-server.config.js
tsx: true,
jsxFactory: 'React.createElement',
jsxFragment: 'Fragment',
target: 'es2020',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in tsconfig.json target is es2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polRk polRk polRk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsuehic @polRk