fix: drop lit-analyzer from deps
#85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to `npx lit-analyzer` to run - drops ~96 package deps, modulo env - drops 4 package warnings
sgammon
commented
Feb 5, 2023
There was a problem hiding this comment.
my environment went from:
Scope: all 9 workspace projects
some/project/here | WARN deprecated [email protected]
some/project/here | WARN deprecated [email protected]
some/project/here | WARN deprecated [email protected]
some/project/here | WARN deprecated [email protected]
some/project/here | WARN deprecated [email protected]
some/project/here | WARN deprecated [email protected]
to:
Scope: all 9 workspace projects
app/ui/frontend | WARN deprecated [email protected]
app/ui/frontend | WARN deprecated [email protected]
pnpm said:
Packages: -96
| @@ -12,7 +12,7 @@ | |||
| "clean": "rimraf my-element.{d.ts,d.ts.map,js,js.map} test/my-element.{d.ts,d.ts.map,js,js.map} test/my-element_test.{d.ts,d.ts.map,js,js.map}", | |||
| "lint": "npm run lint:lit-analyzer && npm run lint:eslint", | |||
| "lint:eslint": "eslint 'src/**/*.ts'", | |||
| "lint:lit-analyzer": "lit-analyzer", | |||
| "lint:lit-analyzer": "npx lit-analyzer", | |||
| @@ -58,7 +58,6 @@ | |||
| "@web/test-runner-playwright": "^0.9.0", | |||
| "@webcomponents/webcomponentsjs": "^2.6.0", | |||
| "eslint": "^8.15.0", | |||
| "lit-analyzer": "^1.2.1", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx lit-analyzerto runsimple change, it also alleviates the need to keep
lit-analyzerup to date