Skip to content

Commit 8eea427

Browse files
lisonglisong
committed
fix
1 parent ff774a4 commit 8eea427

File tree

10 files changed

+46
-46
lines changed

10 files changed

+46
-46
lines changed

‎app.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ app.use(function(req, res, next) {
7474
// development error handler
7575
// will print stacktrace
7676
if (app.get('env') === 'development') {
77-
app.use(function(err, req, res, next) {
77+
app.use(function(err, req, res) {
7878
res.status(err.status || 500);
7979
res.render('error', {
8080
message: err.message,
@@ -85,7 +85,7 @@ if (app.get('env') === 'development') {
8585

8686
// production error handler
8787
// no stacktraces leaked to user
88-
app.use(function(err, req, res, next) {
88+
app.use(function(err, req, res) {
8989
res.status(err.status || 500);
9090
res.render('error', {
9191
message: err.message,

‎core/services/app-manager.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ proto.transferApp = function (appId, fromUid, toUid) {
8383
};
8484

8585
proto.listApps = function (uid) {
86-
let self = this;
86+
const self = this;
8787
return models.Collaborators.findAll({where : {uid: uid}})
8888
.then(function(data){
8989
if (_.isEmpty(data)){

‎core/services/package-manager.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ proto.downloadPackageAndExtract = function (workDirectoryPath, packageHash, blob
160160
}
161161

162162
proto.zipDiffPackage = function (fileName, files, baseDirectoryPath, hotCodePushFile) {
163-
return new Promise(function (resolve, reject, notify) {
163+
return new Promise(function (resolve, reject) {
164164
var zipFile = new yazl.ZipFile();
165165
var writeStream = fs.createWriteStream(fileName);
166166
writeStream.on('error', function (error) {

‎routes/accessKeys.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ var models = require('../models');
77
var middleware = require('../core/middleware');
88
var accountManager = require('../core/services/account-manager')();
99

10-
router.get('/', middleware.checkToken, function(req, res, next) {
10+
router.get('/', middleware.checkToken, function(req, res) {
1111
var uid = req.users.id;
1212
accountManager.getAllAccessKeyByUid(uid)
1313
.then(function(accessKeys){
@@ -18,7 +18,7 @@ router.get('/', middleware.checkToken, function(req, res, next) {
1818
});
1919
});
2020

21-
router.post('/', middleware.checkToken, function(req, res, next) {
21+
router.post('/', middleware.checkToken, function(req, res) {
2222
var uid = req.users.id;
2323
var identical = req.users.identical;
2424
var createdBy = _.trim(req.body.createdBy);
@@ -54,7 +54,7 @@ router.post('/', middleware.checkToken, function(req, res, next) {
5454
});
5555
});
5656

57-
router.delete('/:name', middleware.checkToken, function(req, res, next){
57+
router.delete('/:name', middleware.checkToken, function(req, res){
5858
var name = _.trim(decodeURI(req.params.name));
5959
var uid = req.users.id;
6060
return models.UserTokens.destroy({where: {name:name, uid: uid}})
@@ -66,7 +66,7 @@ router.delete('/:name', middleware.checkToken, function(req, res, next){
6666
});
6767
});
6868

69-
router.patch('/:name', middleware.checkToken, function(req, res, next){
69+
router.patch('/:name', middleware.checkToken, function(req, res){
7070
var name = _.trim(decodeURI(req.params.name));
7171
var friendlyName = _.trim(req.body.friendlyName);
7272
var ttl = _.trim(req.body.ttl);

‎routes/account.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var _ = require('lodash');
55
var security = require('../core/utils/security');
66
var middleware = require('../core/middleware');
77

8-
router.get('/', middleware.checkToken, function(req, res, next) {
8+
router.get('/', middleware.checkToken, function(req, res) {
99
var userInfo = {
1010
email:req.users.email,
1111
id:req.users.identical,

‎routes/apps.js‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const OLD_REGEX_ANDROID = /^(android_)/;
1818
const OLD_REGEX_IOS = /^(ios_)/;
1919

2020
router.get('/',
21-
middleware.checkToken, function(req, res, next) {
21+
middleware.checkToken, function(req, res) {
2222
var uid = req.users.id;
2323
var appManager = new AppManager();
2424
appManager.listApps(uid)
@@ -31,7 +31,7 @@ router.get('/',
3131
});
3232

3333
router.get('/:appName/deployments',
34-
middleware.checkToken, function (req, res, next) {
34+
middleware.checkToken, function (req, res) {
3535
var uid = req.users.id;
3636
var appName = _.trim(req.params.appName);
3737
var deployments = new Deployments();
@@ -48,7 +48,7 @@ router.get('/:appName/deployments',
4848
});
4949

5050
router.post('/:appName/deployments',
51-
middleware.checkToken, function (req, res, next) {
51+
middleware.checkToken, function (req, res) {
5252
var uid = req.users.id;
5353
var appName = _.trim(req.params.appName);
5454
var name = req.body.name;
@@ -66,7 +66,7 @@ router.post('/:appName/deployments',
6666
});
6767

6868
router.get('/:appName/deployments/:deploymentName/metrics',
69-
middleware.checkToken, function (req, res, next) {
69+
middleware.checkToken, function (req, res) {
7070
var uid = req.users.id;
7171
var appName = _.trim(req.params.appName);
7272
var deploymentName = _.trim(req.params.deploymentName);
@@ -111,7 +111,7 @@ router.get('/:appName/deployments/:deploymentName/metrics',
111111
});
112112

113113
router.get('/:appName/deployments/:deploymentName/history',
114-
middleware.checkToken, function (req, res, next) {
114+
middleware.checkToken, function (req, res) {
115115
var uid = req.users.id;
116116
var appName = _.trim(req.params.appName);
117117
var deploymentName = _.trim(req.params.deploymentName);
@@ -138,7 +138,7 @@ router.get('/:appName/deployments/:deploymentName/history',
138138
});
139139

140140
router.delete('/:appName/deployments/:deploymentName/history',
141-
middleware.checkToken, function (req, res, next) {
141+
middleware.checkToken, function (req, res) {
142142
var uid = req.users.id;
143143
var appName = _.trim(req.params.appName);
144144
var deploymentName = _.trim(req.params.deploymentName);
@@ -165,7 +165,7 @@ router.delete('/:appName/deployments/:deploymentName/history',
165165
});
166166

167167
router.patch('/:appName/deployments/:deploymentName',
168-
middleware.checkToken, function (req, res, next) {
168+
middleware.checkToken, function (req, res) {
169169
var name = req.body.name;
170170
var appName = _.trim(req.params.appName);
171171
var deploymentName = _.trim(req.params.deploymentName);
@@ -184,7 +184,7 @@ router.patch('/:appName/deployments/:deploymentName',
184184
});
185185

186186
router.delete('/:appName/deployments/:deploymentName',
187-
middleware.checkToken, function (req, res, next) {
187+
middleware.checkToken, function (req, res) {
188188
var appName = _.trim(req.params.appName);
189189
var deploymentName = _.trim(req.params.deploymentName);
190190
var uid = req.users.id;
@@ -202,7 +202,7 @@ router.delete('/:appName/deployments/:deploymentName',
202202
});
203203

204204
router.post('/:appName/deployments/:deploymentName/release',
205-
middleware.checkToken, function (req, res, next) {
205+
middleware.checkToken, function (req, res) {
206206
var appName = _.trim(req.params.appName);
207207
var deploymentName = _.trim(req.params.deploymentName);
208208
var uid = req.users.id;
@@ -253,7 +253,7 @@ router.post('/:appName/deployments/:deploymentName/release',
253253
});
254254

255255
router.post('/:appName/deployments/:sourceDeploymentName/promote/:destDeploymentName',
256-
middleware.checkToken, function (req, res, next) {
256+
middleware.checkToken, function (req, res) {
257257
var appName = _.trim(req.params.appName);
258258
var sourceDeploymentName = _.trim(req.params.sourceDeploymentName);
259259
var destDeploymentName = _.trim(req.params.destDeploymentName);
@@ -300,7 +300,7 @@ router.post('/:appName/deployments/:sourceDeploymentName/promote/:destDeployment
300300
});
301301
});
302302

303-
var rollbackCb = function (req, res, next) {
303+
var rollbackCb = function (req, res) {
304304
var appName = _.trim(req.params.appName);
305305
var deploymentName = _.trim(req.params.deploymentName);
306306
var uid = req.users.id;
@@ -329,7 +329,7 @@ router.post('/:appName/deployments/:deploymentName/rollback/:label',
329329
middleware.checkToken, rollbackCb);
330330

331331
router.get('/:appName/collaborators',
332-
middleware.checkToken, function (req, res, next) {
332+
middleware.checkToken, function (req, res) {
333333
var appName = _.trim(req.params.appName);
334334
var uid = req.users.id;
335335
var collaborators = new Collaborators();
@@ -354,7 +354,7 @@ router.get('/:appName/collaborators',
354354
});
355355

356356
router.post('/:appName/collaborators/:email',
357-
middleware.checkToken, function (req, res, next) {
357+
middleware.checkToken, function (req, res) {
358358
var appName = _.trim(req.params.appName);
359359
var email = _.trim(req.params.email);
360360
var uid = req.users.id;
@@ -377,7 +377,7 @@ router.post('/:appName/collaborators/:email',
377377
});
378378

379379
router.delete('/:appName/collaborators/:email',
380-
middleware.checkToken, function (req, res, next) {
380+
middleware.checkToken, function (req, res) {
381381
var appName = _.trim(req.params.appName);
382382
var email = _.trim(decodeURI(req.params.email));
383383
var uid = req.users.id;
@@ -404,7 +404,7 @@ router.delete('/:appName/collaborators/:email',
404404
});
405405

406406
router.delete('/:appName',
407-
middleware.checkToken, function (req, res, next) {
407+
middleware.checkToken, function (req, res) {
408408
var appName = _.trim(req.params.appName);
409409
var uid = req.users.id;
410410
var appManager = new AppManager();
@@ -421,7 +421,7 @@ router.delete('/:appName',
421421
});
422422

423423
router.patch('/:appName',
424-
middleware.checkToken, function (req, res, next) {
424+
middleware.checkToken, function (req, res) {
425425
var newAppName = _.trim(req.body.name);
426426
var appName = _.trim(req.params.appName);
427427
var uid = req.users.id;
@@ -460,7 +460,7 @@ router.patch('/:appName',
460460
});
461461

462462
router.post('/:appName/transfer/:email',
463-
middleware.checkToken, function (req, res, next) {
463+
middleware.checkToken, function (req, res) {
464464
var appName = _.trim(req.params.appName);
465465
var email = _.trim(req.params.email);
466466
var uid = req.users.id;
@@ -486,7 +486,7 @@ router.post('/:appName/transfer/:email',
486486
});
487487
});
488488

489-
router.post('/', middleware.checkToken, function (req, res, next) {
489+
router.post('/', middleware.checkToken, function (req, res) {
490490
var appName = req.body.name;
491491
var uid = req.users.id;
492492
var appManager = new AppManager();

‎routes/auth.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var _ = require('lodash');
44
var security = require('../core/utils/security');
55
var accountManager = require('../core/services/account-manager')();
66

7-
router.get('/login', function(req, res, next) {
7+
router.get('/login', function(req, res) {
88
var config = require('../core/config');
99
var codePushWebUrl = _.get(config, 'common.codePushWebUrl');
1010
var isRedirect = false;
@@ -21,11 +21,11 @@ router.get('/login', function(req, res, next) {
2121
}
2222
});
2323

24-
router.get('/link', function(req, res, next) {
24+
router.get('/link', function(req, res) {
2525
res.redirect(`/auth/login`);
2626
});
2727

28-
router.get('/register', function(req, res, next) {
28+
router.get('/register', function(req, res) {
2929
var config = require('../core/config');
3030
var codePushWebUrl = _.get(config, 'common.codePushWebUrl');
3131
var isRedirect = false;
@@ -42,11 +42,11 @@ router.get('/register', function(req, res, next) {
4242
}
4343
});
4444

45-
router.post('/logout', function (req, res, next) {
45+
router.post('/logout', function (req, res) {
4646
res.send("ok");
4747
});
4848

49-
router.post('/login', function(req, res, next) {
49+
router.post('/login', function(req, res) {
5050
var account = _.trim(req.body.account);
5151
var password = _.trim(req.body.password);
5252
var config = require('../core/config');

‎routes/index.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ var middleware = require('../core/middleware');
55
var ClientManager = require('../core/services/client-manager');
66
var _ = require('lodash');
77

8-
router.get('/', function(req, res, next) {
8+
router.get('/', function(req, res) {
99
res.render('index', { title: 'CodePushServer' });
1010
});
1111

12-
router.get('/README.md', function(req, res, next) {
12+
router.get('/README.md', function(req, res) {
1313
var MarkdownIt = require('markdown-it');
1414
const path = require('path');
1515
const fs = require('fs');
@@ -26,11 +26,11 @@ router.get('/README.md', function(req, res, next) {
2626

2727
});
2828

29-
router.get('/tokens', function(req, res, next) {
29+
router.get('/tokens', function(req, res) {
3030
res.render('tokens', { title: '获取token' });
3131
});
3232

33-
router.get('/updateCheck', function(req, res, next){
33+
router.get('/updateCheck', function(req, res){
3434
var deploymentKey = _.get(req, "query.deploymentKey");
3535
var appVersion = _.get(req, "query.appVersion");
3636
var label = _.get(req, "query.label");
@@ -45,7 +45,7 @@ router.get('/updateCheck', function(req, res, next){
4545
});
4646
});
4747

48-
router.post('/reportStatus/download', function(req, res, next){
48+
router.post('/reportStatus/download', function(req, res){
4949
var clientUniqueId = _.get(req, "body.clientUniqueId");
5050
var label = _.get(req, "body.label");
5151
var deploymentKey = _.get(req, "body.deploymentKey");
@@ -57,7 +57,7 @@ router.post('/reportStatus/download', function(req, res, next){
5757
res.send('OK');
5858
});
5959

60-
router.post('/reportStatus/deploy', function(req, res, next){
60+
router.post('/reportStatus/deploy', function(req, res){
6161
var clientUniqueId = _.get(req, "body.clientUniqueId");
6262
var label = _.get(req, "body.label");
6363
var deploymentKey = _.get(req, "body.deploymentKey");
@@ -69,7 +69,7 @@ router.post('/reportStatus/deploy', function(req, res, next){
6969
res.send('OK');
7070
});
7171

72-
router.get('/authenticated', middleware.checkToken, function (req, res, next) {
72+
router.get('/authenticated', middleware.checkToken, function (req, res) {
7373
return res.send({authenticated: true});
7474
})
7575

‎routes/sessions.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var _ = require('lodash');
44
var models = require('../models');
55
var middleware = require('../core/middleware');
66

7-
router.delete('/:machineName', middleware.checkToken, function(req, res, next){
7+
router.delete('/:machineName', middleware.checkToken, function(req, res){
88
var machineName = _.trim(decodeURI(req.params.machineName));
99
var uid = req.users.id;
1010
models.UserTokens.destroy({where: {created_by:machineName, uid: uid}})

‎routes/users.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ var models = require('../models');
66
var middleware = require('../core/middleware');
77
var AccountManager = require('../core/services/account-manager');
88

9-
router.get('/', middleware.checkToken, function(req, res, next) {
9+
router.get('/', middleware.checkToken, function(req, res) {
1010
res.send({ title: 'CodePushServer' });
1111
});
1212

13-
router.post('/', function (req, res, next) {
13+
router.post('/', function (req, res) {
1414
var email = _.trim(_.get(req, 'body.email'));
1515
var token = _.trim(_.get(req, 'body.token'));
1616
var password = _.trim(_.get(req, 'body.password'));
@@ -31,7 +31,7 @@ router.post('/', function (req, res, next) {
3131

3232
});
3333

34-
router.get('/exists', function (req, res, next) {
34+
router.get('/exists', function (req, res) {
3535
var email = _.trim(_.get(req, 'query.email'));
3636
models.Users.findOne({where: {email: email}})
3737
.then(function (u) {
@@ -45,7 +45,7 @@ router.get('/exists', function (req, res, next) {
4545
});
4646
});
4747

48-
router.post('/registerCode', function (req, res, next) {
48+
router.post('/registerCode', function (req, res) {
4949
var email = _.get(req, 'body.email');
5050
var accountManager = new AccountManager();
5151
return accountManager.sendRegisterCode(email)
@@ -57,7 +57,7 @@ router.post('/registerCode', function (req, res, next) {
5757
});
5858
});
5959

60-
router.get('/registerCode/exists', function (req, res, next) {
60+
router.get('/registerCode/exists', function (req, res) {
6161
var email = _.trim(_.get(req, 'query.email'));
6262
var token = _.trim(_.get(req, 'query.token'));
6363
var accountManager = new AccountManager();
@@ -71,7 +71,7 @@ router.get('/registerCode/exists', function (req, res, next) {
7171
});
7272

7373
//修改密码
74-
router.patch('/password', middleware.checkToken, function(req, res, next) {
74+
router.patch('/password', middleware.checkToken, function(req, res) {
7575
var oldPassword = _.trim(_.get(req, 'body.oldPassword'));
7676
var newPassword = _.trim(_.get(req, 'body.newPassword'));
7777
var uid = req.users.id;

0 commit comments

Comments
 (0)