fix: work on fs impl

lishaduck · Nov 20, 2024 · a00b4da · a00b4da
1 parent fb0b1c7
commit a00b4da
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/packages/platform-deno/src/DenoFileSystem.ts b/packages/platform-deno/src/DenoFileSystem.ts
@@ -323,7 +323,6 @@ const makeFile = (() => {
     }
 
     get stat(): Effect.Effect<FileSystem.File.Info, PlatformError> {
-      // FIXME: `makeFileInfo` takes a Deno.FileInfo.
       return Effect.map(fstat(this.fd), makeNodeFileInfo);
     }
 
@@ -340,6 +339,7 @@ const makeFile = (() => {
             this.position += offsetSize;
           }
 
+          // Used in tests.
           return this.position;
         }),
       );
@@ -376,7 +376,7 @@ const makeFile = (() => {
                 buffer,
                 position: this.position,
               }),
-              (bytesRead: number): Option.Option<Uint8Array> => {
+              (bytesRead): Option.Option<Uint8Array> => {
                 if (bytesRead === 0) {
                   return Option.none();
                 }
@@ -386,8 +386,8 @@ const makeFile = (() => {
                   return Option.some(buffer);
                 }
 
-                const dst = new Uint8Array(bytesRead);
-                new Uint8Array(dst).set(new Uint8Array(buffer, 0, bytesRead));
+                const dst = buffer.slice(0, bytesRead);
+
                 return Option.some(dst);
               },
             ),
@@ -402,7 +402,10 @@ const makeFile = (() => {
         Effect.map(
           // FIXME: `truncate` takes a path, not a FileDescriptor.
           // TODO: PR `@effect/platform`, b/c passing a `FileDescriptor` to truncate is also deprecated in Node.js.
-          ftruncateFactory("")(this.fd, length ? Number(length) : undefined),
+          ftruncateFactory("truncate")(
+            this.fd,
+            length ? Number(length) : undefined,
+          ),
           () => {
             if (!this.append) {
               const len = BigInt(length ?? 0);