Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix release workflow warnings #96

Closed
iamazeem opened this issue Dec 23, 2022 · 0 comments · Fixed by #97
Closed

[CI] Fix release workflow warnings #96

iamazeem opened this issue Dec 23, 2022 · 0 comments · Fixed by #97
Assignees
Labels
enhancement New feature or request

Comments

@iamazeem
Copy link
Collaborator

Release (v0.3.4-alpha) CI run: https://github.com/liquidaty/zsv/actions/runs/3660069700

Warnings:

ci (ubuntu-20.04)
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: dawidd6/action-get-tag@v1

ci (ubuntu-20.04)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

ci (macos-12)
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: dawidd6/action-get-tag@v1

ci (macos-12)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

These warnings are coming from:

uses: dawidd6/action-get-tag@v1
if: startsWith(github.ref, 'refs/tags/v')
id: tag
with:
strip_v: true

The rest of the actions have already been updated earlier for NodeJS updates.

https://github.com/dawidd6/action-get-tag has been archived by its author.

As an alternative, the tag can directly be extracted and set like this (lines copied here for quick reference):

    - name: Get tag if tagged/released and set TAG env var
      if: startsWith(github.ref, 'refs/tags/v')
      run: |
        TAG=$(echo $GITHUB_REF | cut -d '/' -f3)
        echo "TAG: $TAG"
        if [[ $TAG == "v"* ]]; then
          TAG="${TAG:1}"
        fi
        echo "TAG: $TAG"
        echo "TAG=$TAG" >> $GITHUB_ENV

I'll submit a PR shortly. Thanks!

CC: @liquidaty

@iamazeem iamazeem added the enhancement New feature or request label Dec 23, 2022
@iamazeem iamazeem self-assigned this Dec 23, 2022
@iamazeem iamazeem changed the title Fix release workflow CI warnings [CI] Fix release workflow warnings Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant