Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for sheet command #209

Closed
iamazeem opened this issue Oct 5, 2024 · 2 comments · Fixed by #210
Closed

Add automated tests for sheet command #209

iamazeem opened this issue Oct 5, 2024 · 2 comments · Fixed by #210
Assignees
Labels
enhancement New feature or request

Comments

@iamazeem
Copy link
Collaborator

iamazeem commented Oct 5, 2024

sheet command has been introduced with 9c5f13d56b798359ab4eb6f1af02d97d76071a96.
Need to add automated tests for this.

@iamazeem iamazeem added the enhancement New feature or request label Oct 5, 2024
@iamazeem iamazeem self-assigned this Oct 5, 2024
@iamazeem iamazeem changed the title Add tests for sheet command Add automated tests for sheet command Oct 5, 2024
@iamazeem
Copy link
Collaborator Author

iamazeem commented Oct 5, 2024

@liquidaty: Here are some observations during testing:

Truncated column and values

zsv-sheet-overview

Small screen crash/segfault (corrupted size vs. prev_size)

zsv-sheet-small-screen-crash-without-tmux

zsv-sheet-small-screen-crash

Header row issue with filter command

zsv-sheet-header-issue-with-filter-command-without-tmux

zsv-sheet-header-issue-with-filter-command

@iamazeem
Copy link
Collaborator Author

iamazeem commented Oct 6, 2024

Just verified that the filter command output is just not a visual glitch.
The header in the captured output is not correct.

Steps to reproduce:

$ cd zsv/app/test
$ make test-sheet
$ tmux new-session -x 1000 -d -s test-sheet "../../build/Linux/rel/gcc/bin/zsv_sheet worldcitiespop_mil.csv" 
$ tmux set-window-option -t test-sheet prefix none
$ tmux send-keys -t test-sheet "f"
$ tmux send-keys -t test-sheet "sarmaj"
$ tmux send-keys -t test-sheet Enter
$ tmux capture-pane -t test-sheet -p > test.log
$ cat test.log
1         ir        sarmaj-e  Sarmaj-e  13                  34.3578
2         ad        aixirival Aixirival 06                  42.466666





















1
$ tmux send-keys -t test-sheet "q"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant