Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings while extracting JQ archive #204

Closed
iamazeem opened this issue Oct 4, 2024 · 3 comments · Fixed by #207
Closed

Fix warnings while extracting JQ archive #204

iamazeem opened this issue Oct 4, 2024 · 3 comments · Fixed by #207
Assignees

Comments

@iamazeem
Copy link
Collaborator

iamazeem commented Oct 4, 2024

On Linux, there are these unknown extended headers warnings while extracting jq-1.6.tar.bz2:

$ cd /home/runner/work/zsv/zsv/build/Linux/rel/musl-gcc/external/jq-src-tmp && tar xf /home/runner/work/zsv/zsv/app/external/jq-1.6.tar.bz2
tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'
tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.provenance'
...

According to this SO thread, the archive needs to recompressed.
Need to test and verity this.

@iamazeem iamazeem self-assigned this Oct 4, 2024
@iamazeem
Copy link
Collaborator Author

iamazeem commented Oct 4, 2024

@liquidaty:
Compared https://github.com/liquidaty/zsv/blob/main/app/external/jq-1.6.tar.bz2 with the official release (https://github.com/jqlang/jq/releases/download/jq-1.6/jq-1.6.tar.gz) and both are identical. 🤔
Seems like ours has been extracted and re-archived on macOS.
Shouldn't we use and store the official one?

Also, there's been new release https://github.com/jqlang/jq/releases/tag/jq-1.7.1 with security fixes.
Shouldn't we use this one?

@iamazeem
Copy link
Collaborator Author

iamazeem commented Oct 5, 2024

@iamazeem
Copy link
Collaborator Author

iamazeem commented Oct 5, 2024

UPDATE
Closed the PR for jq-1.7.1.
Doesn't work with MinGW.
Locally, it compiles fine but the tests fail at runtime.
In CI, the compilation wasn't successful.

jq-1.6 seems to work fine both locally and in the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant