Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make build compatible with new GDAL container TDE-1179 #977

Merged
merged 1 commit into from
May 27, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 26, 2024

Depends on linz/topo-workflows#604.

Make build compatible with GDAL 3.9 container.

  • Use multi-stage build to avoid including build tools in the final image.

  • Install Poetry using pipx, as recommended.

  • Use a different working directory in the first stage, to avoid the possibility of confusing the two or unintended interactions between them.

  • Use a virtualenv to avoid clobbering OS packages.

  • Tests updated (N/A)

  • Docs updated (N/A)

  • Issue linked in Title

This reverts commit 3990bf9.

Make build compatible with [GDAL 3.9
container](#962).

- Use multi-stage build to avoid including build tools in the final
image.
- Install Poetry using pipx, as
[recommended](https://python-poetry.org/docs/#installation).
- Use a different working directory in the first stage, to avoid the
possibility of confusing the two or unintended interactions between
them.
- Use a virtualenv to avoid clobbering OS packages.

- [ ] Tests updated (N/A)
- [ ] Docs updated (N/A)
- [x] Issue linked in Title

This reverts commit 3990bf9.
@l0b0 l0b0 requested a review from a team as a code owner May 26, 2024 22:58
@l0b0 l0b0 added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit f377d61 May 27, 2024
2 checks passed
@l0b0 l0b0 deleted the fix/absolute-path-to-docker-entrypoint branch May 27, 2024 21:41
@github-actions github-actions bot mentioned this pull request May 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 27, 2024
🤖 I have created a release *beep* *boop*
---


## [4.7.1](v4.7.0...v4.7.1)
(2024-05-27)


### Bug Fixes

* Make build compatible with new GDAL container TDE-1179
([#977](#977))
([f377d61](f377d61))


### Reverts

* "fix: Make build compatible with new GDAL container TDE-1179
([#971](#971))"
([#975](#975))
([3990bf9](3990bf9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Victor Engmark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants