feat: add --producer-list to allow multiple producers TDE-781 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajacombs
force-pushed
the
feat/producer-list
branch
from
128d9db
to
2c2a1e0
Compare
paulfouquet
previously approved these changes
Jul 3, 2023
blacha
reviewed
Jul 3, 2023
blacha
previously approved these changes
Jul 3, 2023
blacha
approved these changes
Jul 4, 2023
paulfouquet
approved these changes
Jul 4, 2023
Merged
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Jul 4, 2023
Adds `--producer-list` to the standardising workflow, as implemented by linz/topo-imagery#531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--producer-listargument tocollection_from_items.pyto allow passing multiple producers to the STAC metadata.There is a slight change to how both
--licensor-listand--producer-listare handled, which resolves what I think is an edge case that is currently not handled.Currently, if
--licensor-listis passed a value without;, and--licensoris not passed, the output STAC file will include{ "name": null, "roles": ["licensor"] }. This PR fixes that, so that it will just not be present in the output.Alternatively, it could be included as a single un-split item by removing the
and ";" in arguments.licensor_listchecks.Edit: Which now that I've looked at where it's used in the standardising workflow I see would never eventuate in practice, as
--licensorgets a default value of "Unknown" so--licensoris never not passed a value as the script is used in the standardising workflow (though could be if used elsewhere).