Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable list source TDE-411 #36

Merged
merged 12 commits into from
Jul 10, 2022
Merged

feat: enable list source TDE-411 #36

merged 12 commits into from
Jul 10, 2022

Conversation

MDavidson17
Copy link
Contributor

nargs="+" added to --source to enable multiple input files.

ngars puts all inputs into a list:
One input: --source image.tiff -> [image.tiff]
Multiple Inputs: --source image_one.tiff image_two.tiff -> [image_one.tiff, image_two.tiff]
Using basemaps cli: --source "[\"image_one.tiff\", \"image_two.tiff\"]" -> ["[\"image_one.tiff\", \"image_two.tiff\"]"]

Only the basemaps cli needs to be formatted
["[\"image_one.tiff\", \"image_two.tiff\"]"] -> [image_one.tiff, image_two.tiff]

@MDavidson17 MDavidson17 marked this pull request as ready for review July 4, 2022 01:11
@MDavidson17 MDavidson17 requested a review from a team as a code owner July 4, 2022 01:11
scripts/format_source.py Outdated Show resolved Hide resolved
blacha
blacha previously approved these changes Jul 4, 2022
amfage
amfage previously approved these changes Jul 4, 2022
@MDavidson17 MDavidson17 dismissed stale reviews from amfage and blacha via f7c02d7 July 5, 2022 23:31
@MDavidson17
Copy link
Contributor Author

Code succesfully runs in argo
image

@MDavidson17 MDavidson17 requested a review from amfage July 5, 2022 23:33
amfage
amfage previously approved these changes Jul 6, 2022
Copy link
Collaborator

@paulfouquet paulfouquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments

scripts/format_source.py Outdated Show resolved Hide resolved
scripts/format_source.py Outdated Show resolved Hide resolved
scripts/tests/format_source_test.py Show resolved Hide resolved
scripts/format_source.py Outdated Show resolved Hide resolved
scripts/format_source.py Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit c676b20 into master Jul 10, 2022
@kodiakhq kodiakhq bot deleted the feat/list-source branch July 10, 2022 22:29
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants