fix: accept preset arg standardise-validate #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Aug 29, 2022
scripts/standardising.py
Outdated
|
|
||
| start_standardising(source, arguments.preset, concurrency) | ||
| source = parse_source() | ||
| start_standardising(source, "lzw", 1) |
There was a problem hiding this comment.
shouldn't this also be able to run with webp and mutlithreaded?
There was a problem hiding this comment.
I think we agreed to revisit that when there was a need to run standardise alone. Otherwise mypy complains about code duplication.
There was a problem hiding this comment.
is it time to disable that lint rule? seems very onerous
There was a problem hiding this comment.
another approach would be to allow x lines of duplicated code
There was a problem hiding this comment.
not allowing 4 lines of duplicated code seems like a overly strict rule?
There was a problem hiding this comment.
I've reverted the standardising script to take arguments, pylint seems happy so 🤷
blacha
approved these changes
Aug 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.