Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not logging source as a list of string #116

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: not logging source as a list of string #116

merged 2 commits into from
Aug 29, 2022

Conversation

paulfouquet
Copy link
Collaborator

Description

We should not log the source as list of str: it can be very long, and also Elastic Search is not parsing it correctly.

Change

Remove logging the full source and keeping only logging single file path when needed.

@paulfouquet paulfouquet requested a review from a team as a code owner August 29, 2022 04:20
@kodiakhq kodiakhq bot merged commit a871935 into master Aug 29, 2022
@kodiakhq kodiakhq bot deleted the fix/log-source-as-string branch August 29, 2022 21:15
@github-actions github-actions bot mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfouquet @blacha