Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow forcing Collection title to not have suffix TDE-1289 #1120

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

paulfouquet
Copy link
Collaborator

Motivation

Some datasets might not required a suffix in their title. For example, a dataset with an ongoing lifecycle could not be tagged as a - Draft.

Modifications

  • add an optional parameter --add-title-suffix (defaulted True) to the collection_from_items.py script so the title suffix, for example - Draft can be ommitted in any case

Verification

automatic tests

@paulfouquet paulfouquet added this pull request to the merge queue Oct 10, 2024
Merged via the queue into master with commit 7ca3c43 Oct 10, 2024
2 checks passed
@paulfouquet paulfouquet deleted the feat/allow-title-without-suffix-tde-1289 branch October 10, 2024 02:22
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
🤖 I have created a release *beep* *boop*
---


## [5.1.0](v5.0.2...v5.1.0)
(2024-10-10)


### Features

* allow forcing Collection title to not have suffix TDE-1289
([#1120](#1120))
([7ca3c43](7ca3c43))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Oct 10, 2024
#### Motivation

linz/topo-imagery#1120

#### Modification

- add flag to standardising

#### Checklist

_If not applicable, provide explanation of why._

- [ ] Tests updated
- [ ] Docs updated
- [ ] Issue linked in Title
amfage pushed a commit to linz/topo-workflows that referenced this pull request Nov 14, 2024
#### Motivation

linz/topo-imagery#1120

#### Modification

- add flag to standardising

#### Checklist

_If not applicable, provide explanation of why._

- [ ] Tests updated
- [ ] Docs updated
- [ ] Issue linked in Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants