Skip to content

Commit 17d29ff

Browse files
amadeuszslawinski-intelbroonie
authored andcommitted
ASoC: Intel: Skylake: Use correct function to access iomem space
For copying from __iomem, we should use __ioread32_copy. reported by sparse: sound/soc/intel/skylake/skl-debug.c:437:34: warning: incorrect type in argument 1 (different address spaces) sound/soc/intel/skylake/skl-debug.c:437:34: expected void [noderef] <asn:2> *to sound/soc/intel/skylake/skl-debug.c:437:34: got unsigned char * sound/soc/intel/skylake/skl-debug.c:437:51: warning: incorrect type in argument 2 (different address spaces) sound/soc/intel/skylake/skl-debug.c:437:51: expected void const *from sound/soc/intel/skylake/skl-debug.c:437:51: got void [noderef] <asn:2> *[assigned] fw_reg_addr Signed-off-by: Amadeusz Sławiński <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Pierre-Louis Bossart <[email protected]> Signed-off-by: Mark Brown <[email protected]> Cc: [email protected]
1 parent 0ce6a62 commit 17d29ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/soc/intel/skylake/skl-debug.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ static ssize_t fw_softreg_read(struct file *file, char __user *user_buf,
188188
memset(d->fw_read_buff, 0, FW_REG_BUF);
189189

190190
if (w0_stat_sz > 0)
191-
__iowrite32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2);
191+
__ioread32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2);
192192

193193
for (offset = 0; offset < FW_REG_SIZE; offset += 16) {
194194
ret += snprintf(tmp + ret, FW_REG_BUF - ret, "%#.4x: ", offset);

0 commit comments

Comments
 (0)