Skip to content

Deprecate MarkEventRead function #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

Deprecate MarkEventRead function #753

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e81fb02
Deprecate MarkEventRead API
zliang-akamai May 20, 2025
15221cd
Merge branch 'main' into zhiwei/deprecate-read-event
zliang-akamai Jun 2, 2025
039738d
Update fixtures
zliang-akamai Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions account_events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ func (c *Client) GetEvent(ctx context.Context, eventID int) (*Event, error) {
}

// MarkEventRead marks a single Event as read.
// Deprecated: `MarkEventRead` is a deprecated API, please consider using `MarkEventsSeen` instead.
// Please note that the `MarkEventsSeen` API functions differently and will mark all events up to and
// including the referenced event-id as "seen" rather than individual events.
func (c *Client) MarkEventRead(ctx context.Context, event *Event) error {
e := formatAPIPath("account/events/%d/read", event.ID)
return doPOSTRequestNoRequestResponseBody(ctx, c, e)
Expand Down
Loading