Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated network_ips to nodebalancer to request helpers #543

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated network_ips to nodebalancer and reran fixtures

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner July 8, 2024 13:47
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team July 8, 2024 13:47
@ezilber-akamai ezilber-akamai force-pushed the TPT-2876_network_ips-nodebalancer_configs branch from e7fb171 to bfc5de2 Compare July 8, 2024 14:00
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing on my end, nice work!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, integration tests passed locally with new fixtures

@ezilber-akamai ezilber-akamai merged commit 72ef4eb into linode:main Jul 8, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2876_network_ips-nodebalancer_configs branch July 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants