fix: update MigratingTo field to accept int or null (#736)

* fix: MigratingTo field to accept int or null

The Linode API returns either an Integer or `null` for this field.

* Bump test image version

* Update the test fixture for MigrateTo

* Update the test fixture for InstanceGet test case

* Update the test fixture for list instances test

* Remove unnecessary override as the availability has been expanded

* fix unit test fixtures

* Fix unit test

---------

Co-authored-by: Zhiwei Liang <[email protected]>
Co-authored-by: Zhiwei Liang <[email protected]>

Author: cxdy

instances.go

@@ -151,7 +151,7 @@ type InstancePlacementGroup struct {
 	Label                string               `json:"label"`
 	PlacementGroupType   PlacementGroupType   `json:"placement_group_type"`
 	PlacementGroupPolicy PlacementGroupPolicy `json:"placement_group_policy"`
-	MigratingTo          string               `json:"migrating_to"` // read-only
+	MigratingTo          *int                 `json:"migrating_to"` // read-only
 }
 
 // InstanceMetadataOptions specifies various Instance creation fields

test/integration/fixtures/TestInstance_Get.yaml

@@ -19,9 +19,6 @@ func TestInstances_List_smoke(t *testing.T) {
 	client, instance, _, teardown, err := setupInstanceWithoutDisks(
 		t,
 		"fixtures/TestInstances_List", true,
-		func(client *linodego.Client, options *linodego.InstanceCreateOptions) {
-			options.Region = "eu-west" // Override for metadata availability
-		},
 	)
 
 	defer teardown()
@@ -262,7 +259,7 @@ func TestInstance_MigrateToPG(t *testing.T) {
 		RootPass: randPassword(),
 		Region:   regions[0],
 		Type:     "g6-nanode-1",
-		Image:    "linode/debian10",
+		Image:    "linode/debian12",
 		Booted:   linodego.Pointer(true),
 		PlacementGroup: &linodego.InstanceCreatePlacementGroupOptions{
 			ID: pgOutbound.ID,

test/integration/fixtures/TestInstance_MigrateToPG.yaml

@@ -15,7 +15,7 @@
       "last_successful": "2018-01-01T00:01:01"
     },
     "placement_group": {
-      "migrating_to": "2468"
+      "migrating_to": 2468
     }
 }
 

test/integration/fixtures/TestInstances_List.yaml

@@ -32,7 +32,7 @@
       "placement_group": {
         "id": 528,
         "label": "PG_Miami_failover",
-        "migrating_to": "2468",
+        "migrating_to": 2468,
         "placement_group_policy": "strict",
         "placement_group_type": "anti-affinity:local"
       },

test/integration/instances_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/linode/linodego"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestInstances_List(t *testing.T) {
@@ -41,7 +42,8 @@ func TestInstances_List(t *testing.T) {
 	assert.Equal(t, "us-east", linode.Region)
 	assert.Equal(t, 4096, linode.Specs.Memory)
 	assert.Equal(t, "2018-01-01 00:01:01 +0000 UTC", linode.Backups.LastSuccessful.String())
-	assert.Equal(t, "2468", linode.PlacementGroup.MigratingTo)
+	require.NotNil(t, linode.PlacementGroup.MigratingTo)
+	assert.Equal(t, 2468, *linode.PlacementGroup.MigratingTo)
 }
 
 func TestInstance_Get(t *testing.T) {
@@ -72,7 +74,8 @@ func TestInstance_Get(t *testing.T) {
 	assert.Equal(t, "us-east", instance.Region)
 	assert.Equal(t, 4096, instance.Specs.Memory)
 	assert.Equal(t, "2018-01-01 00:01:01 +0000 UTC", instance.Backups.LastSuccessful.String())
-	assert.Equal(t, "2468", instance.PlacementGroup.MigratingTo)
+	require.NotNil(t, instance.PlacementGroup.MigratingTo)
+	assert.Equal(t, 2468, *instance.PlacementGroup.MigratingTo)
 }
 
 func TestInstance_Migrate(t *testing.T) {