Skip to content

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Jul 28, 2025

General:

Newer versions of linodego added a fix where they error out early if host or scheme are not set. It doesn't automatically use a default value. linode/linodego#758

This PR fixes CCM where it was passing empty value if required var was not set and was then failing.
Fixes #424

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the bugfix for any bug fixes in the changelog. label Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.45%. Comparing base (b0bf52f) to head (1b89f9a).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   72.44%   72.45%   +0.01%     
==========================================
  Files          19       19              
  Lines        3498     3500       +2     
==========================================
+ Hits         2534     2536       +2     
  Misses        733      733              
  Partials      231      231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 merged commit f540796 into main Aug 12, 2025
16 of 21 checks passed
@komer3 komer3 deleted the fix-url branch August 12, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

5 participants