Merge pull request #425 from linode/fix-url

[fix] : add default linode URL

Author: komer3

cloud/linode/client/client.go

@@ -20,6 +20,7 @@ import (
 const (
 	// DefaultClientTimeout is the default timeout for a client Linode API call
 	DefaultClientTimeout = 120 * time.Second
+	DefaultLinodeAPIURL  = "https://api.linode.com"
 )
 
 type Client interface {
@@ -72,6 +73,9 @@ var _ Client = (*linodego.Client)(nil)
 func New(token string, timeout time.Duration) (*linodego.Client, error) {
 	userAgent := fmt.Sprintf("linode-cloud-controller-manager %s", linodego.DefaultUserAgent)
 	apiURL := os.Getenv("LINODE_URL")
+	if apiURL == "" {
+		apiURL = DefaultLinodeAPIURL
+	}
 
 	linodeClient := linodego.NewClient(&http.Client{Timeout: timeout})
 	client, err := linodeClient.UseURL(apiURL)

cloud/linode/cloud_test.go

@@ -20,7 +20,6 @@ func TestNewCloudRouteControllerDisabled(t *testing.T) {
 	t.Setenv("LINODE_API_TOKEN", "dummyapitoken")
 	t.Setenv("LINODE_REGION", "us-east")
 	t.Setenv("LINODE_REQUEST_TIMEOUT_SECONDS", "10")
-	t.Setenv("LINODE_URL", "https://api.linode.com/v4")
 	Options.NodeBalancerPrefix = "ccm"
 
 	t.Run("should not fail if vpc is empty and routecontroller is disabled", func(t *testing.T) {