Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for minio #2

Open
codemonstur opened this issue Aug 28, 2020 · 4 comments · May be fixed by #12
Open

Support for minio #2

codemonstur opened this issue Aug 28, 2020 · 4 comments · May be fixed by #12
Assignees

Comments

@codemonstur
Copy link

I'd like to use this library to talk to a minio server. As far as I can tell the client only supports AWS S3 because of the hardcoding of the Region class. Can this be opened up?

@linktosriram linktosriram self-assigned this Apr 23, 2022
@linktosriram
Copy link
Owner

What changes do you want?

@codemonstur
Copy link
Author

My code has moved on from this and I'm no longer using S3 for file storage. What I needed back when I posted this was a way of setting a hostname-port-region combination for connecting to Minio. s3-lite uses the Region enum for this information. I can't override that or extend it in any way. So s3-lite can only connect to the hardcoded AWS endpoints. Please correct me if I got that wrong.

So what would be needed is a way to instantiate an S3 client using strings and ints.

@linktosriram
Copy link
Owner

Unfortunately Region is currently modelled as an Enum and so it can only contain pre-defined values. A class with a bunch of constants would work

@boaks
Copy link

boaks commented Aug 26, 2022

My experience of the last weeks is, that if you don't want to use AWS S3, just use the default region "us-east-1" and provide the S3 endpoint of your provider, e.g. https://fra1.digitaloceanspaces.com or https://sos-de-fra-1.exo.io. At least using the AWS JDK that's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants