Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended ID transmit doesn't work #12

Open
normaldotcom opened this issue Mar 28, 2019 · 1 comment
Open

Extended ID transmit doesn't work #12

normaldotcom opened this issue Mar 28, 2019 · 1 comment

Comments

@normaldotcom
Copy link

The frameToSlcan(CanFrame frame) does not correctly transmit extended frames; it will only transmit as a standard CAN frame.
@inlacou
Copy link

inlacou commented Feb 6, 2020

Hi,

You need to modify the frameToSlcan(frame: CanFrame): String method in CantactDevice.kt to check CanFrame id length in binary. If length is 29, add "T" and otherwise add "t". The current code does not check length and always adds "t".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@normaldotcom @inlacou