Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the components are labeled with "linkerd.io/control-plane-component" #2602

Closed
alpeb opened this issue Mar 30, 2019 · 2 comments · Fixed by #2820 or #2853
Closed

Make sure all the components are labeled with "linkerd.io/control-plane-component" #2602

alpeb opened this issue Mar 30, 2019 · 2 comments · Fixed by #2820 or #2853
Assignees
@Pothulapati
Labels
area/controller priority/P0 Release Blocker

Comments

@alpeb
Copy link
Member

alpeb commented Mar 30, 2019

At least I know of the proxy-injector's mutating webhook config which is not labelled so.

This allows to act on all Linkerd resources as a whole through label selection.
@alpeb alpeb mentioned this issue Mar 30, 2019
Merged
@Pothulapati
Copy link
Contributor

I'm willing to work on this issue :)

@alpeb
Copy link
Member Author

alpeb commented May 10, 2019

Great! go for it!

/assign @Pothulapati

@Pothulapati Pothulapati mentioned this issue May 14, 2019
Merged
@Pothulapati Pothulapati mentioned this issue May 28, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Pothulapati Pothulapati

Labels
area/controller priority/P0 Release Blocker
Projects
None yet
Milestone
No milestone
3 participants
@grampelberg @alpeb @Pothulapati