Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject: --linkerd-version override is not applied #2551

Closed
olix0r opened this issue Mar 24, 2019 · 4 comments
Closed

inject: --linkerd-version override is not applied #2551

olix0r opened this issue Mar 24, 2019 · 4 comments
Assignees
@olix0r
Labels
area/cli area/inject bug priority/P0 Release Blocker

Comments

@olix0r
Copy link
Member

olix0r commented Mar 24, 2019 •
edited
Loading 

linkerd inject strest.yml --linkerd-version=ver-reconnect-backoff  2>/dev/null |grep -c ver-reconn
0
@ihcsim
Copy link
Contributor

ihcsim commented Mar 24, 2019

Related to #2497.

@olix0r olix0r self-assigned this Mar 26, 2019
@olix0r
Copy link
Member Author

olix0r commented Mar 26, 2019

It's convenient to fix this with #2556, so i'll take it

This was referenced Mar 26, 2019
Merged
Merged
@ihcsim
Copy link
Contributor

ihcsim commented Mar 26, 2019

Fixed under #2547.

@ihcsim ihcsim closed this as completed Mar 26, 2019
@ihcsim
Copy link
Contributor

ihcsim commented Mar 26, 2019

The overridden linkerd version needs to be encoded as annotation. Re-opening issue.

@ihcsim ihcsim reopened this Mar 26, 2019
@ihcsim ihcsim added priority/P1 Planned for Release and removed priority/P0 Release Blocker labels Mar 26, 2019
@ihcsim ihcsim mentioned this issue Mar 29, 2019
Merged
@admc admc added priority/P0 Release Blocker and removed priority/P1 Planned for Release labels Apr 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@olix0r olix0r

Labels
area/cli area/inject bug priority/P0 Release Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@admc @olix0r @ihcsim