-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to inject to set resource limits #2029
Comments
It's a really great idea! I'd like just to say that it maybe would be interesting if the parameters to set the Something like: --proxy-memory-requests and --proxy-memory-limits. I believe that this can avoid some misunderstanding. |
This is also important if a pod needs to have a specific |
TIL, I've not played around with the |
Feature Request
Currently there is an option to set the memory and CPU requests via
--proxy-memory
and--proxy-cpu
but there is no way to set the limits without hand-editing the manifests.What problem are you trying to solve?
Setting the resource limits to prevent runaway usage in case of a memory or CPU leak.
How should the problem be solved?
Add in an option
--proxy-memory-limit
and--proxy-cpu-limit
to set the limits.What do you want to happen? Add any considered drawbacks.
Probably best to not overload the existing CLI options for requests.
Any alternatives you've considered?
No
Is there another way to solve this problem that isn't as good a solution?
Manually adjusting the manifests.
How would users interact with this feature?
CLI
If you can, explain how users will be able to use this. Maybe some sample CLI
output?
helm get manifest mychart |linkerd inject --proxy-cpu-limit=100m --proxy-cpu=100m --proxy-memory-limit=128Mi --proxy-memory=100Mi - |kubectl apply -f -
Would create output:
resources: limits: cpu: 100m memory: 128Mi requests: cpu: 100m memory: 100Mi
The text was updated successfully, but these errors were encountered: