Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override tag for the controller image #11269

Closed
alpeb opened this issue Aug 18, 2023 · 3 comments
Closed

Add ability to override tag for the controller image #11269

alpeb opened this issue Aug 18, 2023 · 3 comments

Comments

@alpeb
Copy link
Member

alpeb commented Aug 18, 2023

Currently the container images in the manifests for the linkerd core controllers have their tags parametrized to {{.Values.linkerdVersion}}. There are circumstances (like pointed out here) were we'd like to override this. The solution would be to add something like a controllerImageVersion entry in values.yaml with an empty string default, and use that in the templates if non-empty (via helm's default function).

@utibeabasi6
Copy link

hey
i would like to work on this if its still open
maybe some guidance to help me get started

@wasup-yash
Copy link

This issue seems to be resolved, as per this

@alpeb
Copy link
Member Author

alpeb commented Oct 11, 2023

Fixed by #11406

@alpeb alpeb closed this as completed Oct 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants