Skip to content

Commit cad0ca3

Browse files
Cameron Boultonhawkw
Cameron Boulton
authored andcommitted
Restart destination, proxy-injector controllers on config change. (#11440)
Fixes #6940 Added a `checksum/config` annotation into the destination, proxy-injector and tap-injector workloads, whose value is calculated as the SHA256 of the template file containing the TLS cert they depend on. This is necessary so that every time those other files change (they get re-generated on every upgrade or config update via `linkerd upgrade`), the workloads change as well. We had this in place before, but with the 2.12 helm charts migrations we dropped it by mistake. Signed-off-by: Cameron Boulton <[email protected]>
1 parent 9467bcc commit cad0ca3

19 files changed

+36
-0
lines changed

charts/linkerd-control-plane/templates/destination.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ spec:
153153
template:
154154
metadata:
155155
annotations:
156+
checksum/config: {{ include (print $.Template.BasePath "/destination-rbac.yaml") . | sha256sum }}
156157
{{ include "partials.annotations.created-by" . }}
157158
{{- include "partials.proxy.annotations" . | nindent 8}}
158159
{{- with .Values.podAnnotations }}{{ toYaml . | trim | nindent 8 }}{{- end }}

charts/linkerd-control-plane/templates/proxy-injector.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ spec:
3232
template:
3333
metadata:
3434
annotations:
35+
checksum/config: {{ include (print $.Template.BasePath "/proxy-injector-rbac.yaml") . | sha256sum }}
3536
{{ include "partials.annotations.created-by" . }}
3637
{{- include "partials.proxy.annotations" . | nindent 8}}
3738
{{- with .Values.podAnnotations }}{{ toYaml . | trim | nindent 8 }}{{- end }}

cli/cmd/testdata/install_controlplane_tracing_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_custom_domain.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_custom_registry.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_default.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_default_override_dst_get_nets.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_default_token.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_ha_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_ha_with_overrides_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_heartbeat_disabled_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_helm_control_plane_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_helm_control_plane_output_ha.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_helm_output_ha_labels.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_helm_output_ha_namespace_selector.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_no_init_container.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_output.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_proxy_ignores.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/cmd/testdata/install_values_file.golden

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)