Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guava compile dependencies on runtime classpath #1934

Open
robobario opened this issue Oct 31, 2022 · 3 comments · May be fixed by #1935
Open

Guava compile dependencies on runtime classpath #1934

robobario opened this issue Oct 31, 2022 · 3 comments · May be fixed by #1935

Comments

@robobario
Copy link
Contributor

Hi, we build/run cruise-control and noticed that some guava compile dependencies are on the runtime path. As a user we'd like the minimum set of dependencies on the classpath. We currently exclude them in our build and wondered if it was worth doing the same upstream.

They are:

com.google.code.findbugs:jsr305
com.google.errorprone:error_prone_annotations
com.google.j2objc:j2objc-annotations
org.checkerframework:checker-qual

https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies

Thank you
@robobario robobario linked a pull request Oct 31, 2022 that will close this issue
Open
@CCisGG
Copy link
Contributor

CCisGG commented Nov 23, 2022 •
edited
Loading

Hi @robobario , I think the intent is reasonable at least for your use cases. I'm concerned about what if in the future people make some changes that needs those dependencies? Or if people have their own CC branches that need some of those dependencies.

@CCisGG
Copy link
Contributor

CCisGG commented Nov 23, 2022

I feel it's still safe to leave it there, unless it would affect performance or will add notable complexity during building or runtime.

@robobario
Copy link
Contributor Author

True, it's safest to leave it since there's caveats around reflective access, maybe it'd break something in future. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude guava compile dependencies from runtime robobario/cruise-control
2 participants
@robobario @CCisGG