Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <Select /> pseudolocalization #961

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

MartinCerny-awin
Copy link
Contributor

@MartinCerny-awin MartinCerny-awin commented Jan 26, 2021

This closes #743

@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/6x94b1f6f
✅ Preview: https://js-lingui-git-fork-martincerny-awin-pseudolocalize-select.lingui-js.now.sh

Copy link
Contributor

@semoal semoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm you forgot to change on R.compose the delimiters function

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #961 (7572417) into main (353c537) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   83.51%   83.51%           
=======================================
  Files          53       53           
  Lines        1601     1601           
  Branches      428      428           
=======================================
  Hits         1337     1337           
  Misses        154      154           
  Partials      110      110           
Impacted Files Coverage Δ
packages/cli/src/api/pseudoLocalize.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353c537...7572417. Read the comment docs.

@semoal semoal merged commit f1e1a25 into lingui:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pseudo Localization] Syntax tokens shouldn't be pseudo localized
2 participants