Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: t macro as function not extracting #846

Merged
merged 3 commits into from
Nov 11, 2020
Merged

fix: t macro as function not extracting #846

merged 3 commits into from
Nov 11, 2020

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Nov 10, 2020

Will close #844

@vercel
Copy link

vercel bot commented Nov 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/pzm6tqv5p
✅ Preview: https://js-lingui-git-fix-macro-t.lingui-js.vercel.app

@tricoder42
Copy link
Contributor

@semoal I've pushed one commit which seems to fix the issue. Please take a look and merge at your will 👍

@semoal semoal merged commit d819bfc into main Nov 11, 2020
@semoal semoal deleted the fix-macro-t branch November 11, 2020 08:22
@tricoder42
Copy link
Contributor

Do you want to release the patch or should we wait for more fixes?

@semoal
Copy link
Contributor Author

semoal commented Nov 11, 2020

Let me take a look to that windows issue. This morning i could get it fixed, if not we just deploy the patch this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function t macros do not get extracted
2 participants