Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit 1 on strict mode of compile #825

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: exit 1 on strict mode of compile #825

merged 1 commit into from
Nov 5, 2020

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Nov 5, 2020

Will close #722

@vercel
Copy link

vercel bot commented Nov 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/74w30m3et
✅ Preview: https://js-lingui-git-fix-exit-1-strict.lingui-js.vercel.app

tricoder42
tricoder42 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@tricoder42 tricoder42 merged commit 69a80e2 into lingui:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tricoder42 tricoder42 tricoder42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a CLI command to validate the catalog on CI
2 participants
@semoal @tricoder42