-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved performance of formatters #818
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/7w4ggsq7k |
Awesome! Pretty good performance boost 👍 |
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
==========================================
+ Coverage 84.71% 84.81% +0.10%
==========================================
Files 39 39
Lines 1295 1317 +22
Branches 341 349 +8
==========================================
+ Hits 1097 1117 +20
- Misses 117 118 +1
- Partials 81 82 +1
Continue to review full report at Codecov.
|
Nice! Looks good to me 🚀 |
Will close #472
I've added to format functions a third param to disable/enable the memoize function for testing purposes in that way we can be 100% sure that the cache is working properly.
Some results (1000x renders of
date
)Some results (1000x renders of
number
)