Log original error with Babel compatibility info #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, thank you! I just made minor fixes with prettier to make linter happier. |
|
Released in 2.7.3 |
Photonios
pushed a commit
to SectorLabs/js-lingui
that referenced
this pull request
Dec 9, 2019
* Log original error with Babel compatibility info * style: fix linter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem where lingui thought I needed to install
babel-coreversion 6 however the actual problem was being obscured because the error message which prompts lingui to log these instructions is not itself shared with the developer.The actual problem I was having was that the lib
babel-preset-react-appwas not up-to-date, so the instructions to "please install missing Babel 6 core package" were misleading.This PR makes the Babel compat. messages also print the original error in order to help people debugging cases like this.
Thanks for a great library!
Edit: Let me know what needs to be done re: tests and I will fix up the PR accordingly.