feat(react): native support react RSC #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
timofei-iatsenko
force-pushed
the
feature/react-rsc
branch
from
2493e08
to
7b416f4
Compare
andrii-bodnar
approved these changes
Apr 12, 2024
|
@thekip let's ship it in v4? |
timofei-iatsenko
force-pushed
the
feature/react-rsc
branch
from
d9d94e2
to
315a5b2
Compare
|
Rebased and changed the base, this one #1915 is also important to be merged to make it work. |
|
@thekip could you please rebase the #1915 as well? There are some e2e tests failing btw |
|
Just found that splitting macro to two packages not in the main branch, so the fix #1915 is not needed right now. |
|
Also i have completely no idea how to test changes from this PR. Probably the only one way is full e2e test on nextjs application using cypress/playwright |
|
Probably this is the only way |
|
@thekip I'd like to make a new 4.9.0 release. Is there anything that is required for this release? |
|
@andrii-bodnar please, go ahead |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring to the React package primitives for comfortable work with RSC
Related discussion: #1903 (comment)
Here is example using it: timofei-iatsenko/nextjs-lingui-rsc-poc#3
Types of changes
Fixes # (issue)
Checklist