Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use named instead of default export for unraw lib #1837

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

fixes: #1836 (comment)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 9:16am

Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.81 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54875d5) 76.28% compared to head (1114145) 76.39%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   76.28%   76.39%   +0.11%     
==========================================
  Files          81       81              
  Lines        2075     2072       -3     
  Branches      529      529              
==========================================
  Hits         1583     1583              
+ Misses        380      377       -3     
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar
Copy link
Contributor

@thekip thank you!

@andrii-bodnar andrii-bodnar merged commit 85f0944 into lingui:main Jan 17, 2024
16 checks passed
@timofei-iatsenko timofei-iatsenko deleted the fix/default-unraw-import branch January 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unraw default export resolution error in React Native 0.73.2
2 participants