Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vite-plugin): report user-friendly error when macro used without… #1720

Merged
merged 1 commit into from
Jun 29, 2023
Merged

feat(vite-plugin): report user-friendly error when macro used without… #1720

merged 1 commit into from
Jun 29, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

… transformation

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jun 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 3:04pm

@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review June 28, 2023 15:01
@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.76 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@andrii-bodnar
Copy link
Contributor

@thekip thank you!

@andrii-bodnar andrii-bodnar merged commit 53f6a7c into lingui:main Jun 29, 2023
11 checks passed
@timofei-iatsenko timofei-iatsenko deleted the error-macro-report-vite branch June 29, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timofei-iatsenko @andrii-bodnar