feat: clarify the order by messageId in v4 and support order by message

[taozhou-glean]

Description

SInce the hash id support is in, the messageId now becomes the linguiId when custom id is absent. This is a change of behavior compared to v3, so its worth clarifying in the doc.

And to preserve the v3 behavior as much as we can, I am adding a new orderBy (message), so when no custom id is used, the order by message should match what messageId is expected in v3.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Fixes # (issue) #1514

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 14, 2023 at 3:07PM (UTC)

[taozhou-glean]

I thought about renaming or adding linguiId as an option, but feel like it may be misleading itself, as we do use custom message id as messageId if exists. And support purely order by linguiId seems not that helpful at the moment. So only adding the message here.

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.57 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.67 KB (0%)
./packages/remote-loader/build/esm/index.js	7.25 KB (0%)

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (580e702) 74.04% compared to head (8a90b3e) 74.19%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1515      +/-   ##
==========================================
+ Coverage   74.04%   74.19%   +0.14%     
==========================================
  Files          67       67              
  Lines        1865     1868       +3     
  Branches      491      494       +3     
==========================================
+ Hits         1381     1386       +5     
+ Misses        382      380       -2     
  Partials      102      102              

Impacted Files	Coverage Δ
packages/cli/src/api/catalog.ts	90.81% <100.00%> (+0.59%)	⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[andrii-bodnar]

@taozhou-glean thank you!

[timofei-iatsenko]

Thanks for contribution. I also thinks that sort by message should be a default one. Because this would be less breaking for most supported usecase.

For those who uses explicit ids there always an option to enable "messageId" sort manually

[taozhou-glean]

Thanks for contribution. I also thinks that sort by message should be a default one. Because this would be less breaking for most supported usecase.

For those who uses explicit ids there always an option to enable "messageId" sort manually

I would +1 on that, can do that in a follow up if @andrii-bodnar also agrees on this.

[andrii-bodnar]

@taozhou-glean sounds good to me

[taozhou-glean]

@taozhou-glean sounds good to me

@andrii-bodnar cool, will change the default orderBy in #1519, less change than expected, gonna rebase once this is merged, not including it in this PR just to make change more readable from commit perspective.