feat(macro): throw useful error message if macro used without a plugin #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Martin005
suggested changes
Jan 25, 2023
packages/macro/src/index.ts
Outdated
Comment on lines
153
to
166
| const macros = [ | ||
| 'defineMessage', | ||
| 'arg', | ||
| 't', | ||
| 'plural', | ||
| 'select', | ||
| 'selectOrdinal', | ||
|
|
||
| // jsx | ||
| 'Trans', | ||
| 'Plural', | ||
| 'Select', | ||
| 'SelectOrdinal', | ||
| ]; |
There was a problem hiding this comment.
I don't think it is a good idea to have two identical lists of tag names (the other is in the getMacroType function). Please merge these two concepts into a dictionary, update the forEach below, remove the getMacroType function and update getting the macro type on the line 43.
packages/macro/src/index.ts
Outdated
| @@ -149,3 +149,29 @@ function getMacroType(tagName: string): string { | |||
| } | |||
|
|
|||
| export default createMacro(macro) | |||
There was a problem hiding this comment.
I think that this export statement should be at the end of file.
packages/macro/src/index.ts
Outdated
| throw new Error(`The macro you imported from "@lingui/macro" is being executed outside the context of compilation with babel-plugin-macros. ` | ||
| + `This indicates that you don't have the babel plugin "babel-plugin-macros" configured correctly. ` | ||
| + `Please see the documentation for how to configure babel-plugin-macros properly: ` | ||
| + 'https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md'); |
There was a problem hiding this comment.
Suggested change
| + 'https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md'); | |
| + 'https://github.com/kentcdodds/babel-plugin-macros/blob/main/other/docs/user.md'); |
packages/macro/test/index.ts
Outdated
| return (mod as unknown as typeof import('@lingui/macro')).Trans | ||
| } | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `The macro you imported from "@lingui/macro" is being executed outside the context of compilation with babel-plugin-macros. This indicates that you don't have the babel plugin "babel-plugin-macros" configured correctly. Please see the documentation for how to configure babel-plugin-macros properly: https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md` |
There was a problem hiding this comment.
Suggested change
| `The macro you imported from "@lingui/macro" is being executed outside the context of compilation with babel-plugin-macros. This indicates that you don't have the babel plugin "babel-plugin-macros" configured correctly. Please see the documentation for how to configure babel-plugin-macros properly: https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md` | |
| `The macro you imported from "@lingui/macro" is being executed outside the context of compilation with babel-plugin-macros. This indicates that you don't have the babel plugin "babel-plugin-macros" configured correctly. Please see the documentation for how to configure babel-plugin-macros properly: https://github.com/kentcdodds/babel-plugin-macros/blob/main/other/docs/user.md` |
timofei-iatsenko
force-pushed
the
feature/throw-error-from-macro
branch
from
8201664
to
b54270e
Compare
timofei-iatsenko
force-pushed
the
feature/throw-error-from-macro
branch
from
b54270e
to
a1c77ff
Compare
|
@Martin005 done |
Martin005
reviewed
Jan 25, 2023
Martin005
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.