Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): catalogsMergePath doesn't merge catalogs #1341

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

Martin005
Copy link
Contributor

This PR fixes #1233.
Previously, the catalogs were not merge even if catalogsMergePath option was provided in the configuration. The getCatalogForMerge() function was never called from the code (it was used only in tests).

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 7:47PM (UTC)

@github-actions
Copy link

github-actions bot commented Jan 16, 2023

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.87 KB (0%)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.91 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 17.56 KB (0%)

@timofei-iatsenko
Copy link
Collaborator

It should be automatically tested somehow. Could you create a test for that?

@Martin005
Copy link
Contributor Author

It should be automatically tested somehow. Could you create a test for that?

There are already tests for getCatalogForMerge() function. As for testing the lingui-compile.ts file, we don't currently have tests for any of our CLI commands – maybe we could add tests in a separate PR.

@andrii-bodnar andrii-bodnar merged commit 12ad0df into main Jan 17, 2023
@andrii-bodnar andrii-bodnar deleted the fix/catalogsMergePath branch January 17, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catalogsMergePath doesn't merge all the catalogs
3 participants