fix(types): <Trans>can have an i18n props
#1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you need to force the `i18n` instance used by `<Trans>`. In my case, it is to have a server-side render of a React PDF document, where I do not have a global `i18n` instance but several global ones (one per language).
The macro seems to properly handle this, and this patch works fine locally with our app.
For example:
```
component Test = () => {
const i = useLingui()
return <Text><Trans i18n={i.i18n}>Test String</Trans></Text>
}
```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportBase: 82.52% // Head: 82.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 56 56
Lines 1785 1785
Branches 500 500
=======================================
Hits 1473 1473
Misses 184 184
Partials 128 128 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you need to force the
i18ninstance used by<Trans>. In my case, it is to have a server-side render of a React PDF document, where I do not have a globali18ninstance but several global ones (one per language).The macro seems to properly handle this, and this patch works fine locally with our app.
For example: