fix: JSX attribute parsing issue when using double quotes

[skovhus]

• Fixes Quoted JSX attributes use XML-style escapes #1225

This was the least intrusive way I could come up with by wrapping the relevant jsxAttribute string literal value in a jsxExpressionContainer.

This is currently done conditionally in case the message includes a double quote. Note that I believe this could safely be done unconditionally, but it requires updating a lot of tests. I happily do this if we like the suggested solution.

This has been tested out on a fairly big codebase.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/4b45GDoiHUkZoH333z3nYLrhfk66
✅ Preview: Failed

[codecov]

Codecov Report

Merging #1226 (8828750) into main (0e270a3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
+ Coverage   81.66%   81.69%   +0.03%     
==========================================
  Files          56       56              
  Lines        1767     1770       +3     
  Branches      490      491       +1     
==========================================
+ Hits         1443     1446       +3     
  Misses        194      194              
  Partials      130      130              

Impacted Files	Coverage Δ
packages/macro/src/macroJsx.ts	91.36% <100.00%> (+0.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e270a3...8828750. Read the comment docs.

[skovhus]

@semoal Note that I've been testing this out on a fairly big project and haven't identified any issues.

[skovhus]

Let me know if I can help fixing the Vercel CI error.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
js-lingui	❌ Failed (Inspect)		Apr 20, 2022 at 0:16AM (UTC)

[skovhus]

Removing the conditional here seems safe – I've done this in a larger codebase.

Let me know if we should remove the conditional here (a lot of the tests would need to be updated).

[skovhus]

@semoal Let me know if we should remove the conditional here (a lot of the tests would need to be updated).

[semoal]

Will that imply a breaking change? Sorry but I don't get why we should update the tests?

[skovhus]

It will not introduce a breaking change, but as all id and and message attribute will now be wrapped in an expression, then all the tests would need to be updated.

So instead of <Trans id="test" /> it would be <Trans id={"test"} />. Again not breaking change.

Keeping the conditional might be a fine tradeoff, then we only wrap the attributes in an expression in case there is a " in them.

[skovhus]

We should remove the conditional here to handle additional corner cases. This was done in #1234

[semoal]

Super cool, thanks for the contribution mate