fix(macro): add lingui peer dependencies #1187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @lingui/macro generates code, it could create imports using
@lingui/core
or
@lingui/react
With PNPM dependency manager, we need those peer dependencies, otherwise the build
could fail as we'll have missing or wrong dependencies.
Currently in one of our monorepo using different versions of lingui (v2 and v3),
typescript gets confused when we use
@lingui/macro@v3
. It sometimes resolves@lingui/core@v2
even if ourpackage.json
dependencies declare@lingui/core@v3
.By setting
@lingui/macro
peer dependencies, the problem disappears