Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n.activate should load instantly new messages #1182

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Jan 1, 2022

Will close #1181

@vercel
Copy link

vercel bot commented Jan 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/Cdr8proxBZqgvgyhXhhBi6dx8t8E
✅ Preview: Failed

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #1182 (dddccbb) into main (5feb120) will decrease coverage by 0.10%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   81.71%   81.60%   -0.11%     
==========================================
  Files          56       56              
  Lines        1766     1767       +1     
  Branches      490      490              
==========================================
- Hits         1443     1442       -1     
- Misses        192      195       +3     
+ Partials      131      130       -1     
Impacted Files Coverage Δ
packages/core/src/i18n.ts 67.18% <28.57%> (-4.25%) ⬇️
packages/macro/src/index.ts 83.33% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5feb120...dddccbb. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 1, 2022

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.84 KB (-0.04% 🔽)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 92.03 KB (0%)

Copy link

@sakulstra sakulstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just running into this issue as well and the pr seems to fix it for me.

@semoal semoal merged commit f8f47a2 into main Jan 21, 2022
@semoal
Copy link
Contributor Author

semoal commented Jan 21, 2022

Will try to release a new version along today

@semoal semoal deleted the fix-i18n-activate-should-load-instantly branch January 21, 2022 14:29
@divyansh7924
Copy link

@semoal
Try running the following code, this test fails, hope this helps debugging the issue
https://github.com/lingui/js-lingui/compare/main...divyansh7924:js-lingui:test-fail?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n.activate(language) takes time to activate language
3 participants