Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): unicode chars were removed from .po files when extracting #1125

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Sep 1, 2021

Will close #1098

@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/AQqiAJhvZ5KR8YoASsybZTs2VFku
✅ Preview: https://js-lingui-git-semoal-fix-1098-lingui-js.vercel.app

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.79 KB (+0.43% 🔺)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (0%)
./packages/remote-loader/build/cjs/remote-loader.production.min.js 92.03 KB (0%)

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1125 (9fd41c4) into main (3b449b7) will not change coverage.
The diff coverage is 25.00%.

❗ Current head 9fd41c4 differs from pull request most recent head da1ffb5. Consider uploading reports for the commit da1ffb5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files          56       56           
  Lines        1677     1677           
  Branches      459      459           
=======================================
  Hits         1380     1380           
  Misses        173      173           
  Partials      124      124           
Impacted Files Coverage Δ
packages/core/src/context.ts 80.76% <0.00%> (ø)
packages/core/src/i18n.ts 75.43% <0.00%> (ø)
packages/macro/src/macroJsx.ts 90.97% <0.00%> (ø)
packages/macro/src/macroJs.ts 90.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b449b7...da1ffb5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode characters are removed from .po when they are in msgstr
1 participant