Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'compile --watch' not watching for correct file based on format #1088

Merged

Conversation

luludan
Copy link
Contributor

@luludan luludan commented Jun 16, 2021

Currently the --watch option for compile only works for po format. This is because the file extension matches the format.

For other format options like minimal then currently the watcher is looking for files with a .minimal extension rather than a .json extension.

@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/CGJE9qU7KM2tpqMSgc7FN6M8D2AV
✅ Preview: https://js-lingui-git-fork-luludan-fix-compile-watch-c-e5ee31-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1088 (f6fdd0e) into main (cee63c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files          56       56           
  Lines        1678     1678           
  Branches      458      458           
=======================================
  Hits         1381     1381           
  Misses        173      173           
  Partials      124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd464d...f6fdd0e. Read the comment docs.

@semoal semoal changed the title fix: 'compile --watch' not watching for correct file extention based on format fix: 'compile --watch' not watching for correct file based on format Jun 17, 2021
@semoal semoal merged commit ab68c06 into lingui:main Jun 17, 2021
@semoal
Copy link
Contributor

semoal commented Jun 17, 2021

Looks good, nice catch! I'll release it tomorrow probably. Thanks for the contribution mate

@semoal semoal mentioned this pull request Sep 2, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants