Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event emitter refactor (reverted) #1038

Merged
merged 1 commit into from
Apr 9, 2021
Merged

fix: event emitter refactor (reverted) #1038

merged 1 commit into from
Apr 9, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Apr 9, 2021

This reverts commit a7aa6a6.

@vercel
Copy link

vercel bot commented Apr 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/GTiRq7WdiRsw8Upj8w87oc7854SW
✅ Preview: https://js-lingui-git-fix-native-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1038 (b7bf731) into main (3653f6f) will increase coverage by 1.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   81.21%   83.06%   +1.84%     
==========================================
  Files          53       53              
  Lines        1693     1624      -69     
  Branches      455      443      -12     
==========================================
- Hits         1375     1349      -26     
+ Misses        196      158      -38     
+ Partials      122      117       -5     
Impacted Files Coverage Δ
packages/core/src/i18n.ts 75.43% <ø> (ø)
packages/core/src/eventEmitter.ts 100.00% <100.00%> (+53.75%) ⬆️
packages/react/src/I18nProvider.tsx 83.87% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3653f6f...b7bf731. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

size-limit report 📦

Path Size
./packages/core/build/cjs/core.production.min.js 2.78 KB (-23.92% 🔽)
./packages/detect-locale/build/cjs/detect-locale.production.min.js 798 B (0%)
./packages/react/build/cjs/react.production.min.js 4.85 KB (+0.11% 🔺)

@semoal semoal changed the title Revert "fix: event emitter improvement" fix: event emitter refactor (reverted) Apr 9, 2021
@semoal semoal merged commit f299493 into main Apr 9, 2021
@semoal semoal deleted the fix-native branch April 9, 2021 12:21
@kopax-polyconseil
Copy link

kopax-polyconseil commented Apr 9, 2021

I am receiving a bunch of testeurs and developer complaining about variable interpolation and unicodes chars.

Can we conclude the PP session? Otherwise, I must downgrade to v2 and won't be able to support further in those investigations.

That's just another example which involve dev an testeurs: https://github.com/pass-culture/pass-culture-app-native/pull/861/files

@semoal
Copy link
Contributor Author

semoal commented Apr 9, 2021

I am receiving a bunch of testeurs and developer complaining about variable interpolation and unicodes chars.

Can we conclude the PP session? Otherwise, I must downgrade to v2 and won't be able to support further in those investigations.

That's just another example which involve dev an testeurs: pass-culture/pass-culture-app-native#861 (files)

Just did an update in the other thread, i'm going to lunch (give me 40 mins) and we can pp other time and we try to resolve everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants