ProgressBar Widget Port #133
Conversation
src/view/progress_bar.rs
Outdated
| _message: Box<dyn Any>, | ||
| _app_state: &mut T, | ||
| ) -> MessageResult<A> { | ||
| MessageResult::Nop |
There was a problem hiding this comment.
Although I agree with Raph, that it should be a logic error when a message reaches this, Stale may be more appropriate here (it's also used in other views/widgets that don't emit messages/events)? Maybe a new MessageResult::Error variant makes sense?
I could also imagine a panic here in debug builds at least.
giannissc
force-pushed
the
progress-bar
branch
from
b3ead98 to
4ebabde
Compare
giannissc
force-pushed
the
progress-bar
branch
from
5b2ead8 to
14f091e
Compare
|
Should this be merged? I rebased on top of the master @Philipp-M |
|
Haven't had yet time to review the progress bar in detail, it looks like this contains the Switch PR (#132) as well? I think it would be easier to split the Switch into its own PR (any reason why #132 was closed?). I can quickly approve #132 (or similar) (would be cool to address the remaining review comments, but they're just nit-picks, so not that important). |
|
I am not sure what happened there.. I thought it got submitted and that why I couldn't find it. I will revive it and rebase both and address the comments so that they can both be submitted. |
|
I think, since you have used the main branch for that PR, and you have synced with the current linebender main branch, that since there weren't any changes in the PR anymore, that the PR has maybe closed itself? I'm not sure though, it hasn't happened to me yet (but I'm not sure if I ever had such a case). |
|
This PR was made for Xilem classic and is now superseded by #513. I'm closing this. |
No description provided.