Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

What to do with presentation strategy logic? #18

Closed
bzm3r opened this issue Oct 18, 2022 · 1 comment
Closed

What to do with presentation strategy logic? #18

bzm3r opened this issue Oct 18, 2022 · 1 comment
Labels
unpiet Uncoupling piet and glazier

Comments

@bzm3r
Copy link

bzm3r commented Oct 18, 2022

I am working on silencing some clippy lints, which is pointing me to consider what is happening with regards to presentation strategy in druid-shell:

let dxgi_state = unsafe {

compared to in unpiet, where presentation strategy logic goes out the window:

let handle = self.handle.borrow().to_owned();

Tracing various threads back, I am lead to the blocker being create_dxgi_state, particularly the creation of a D3D11Device, as explained by Raph here.

Which leads me to wonder: does the presentation strategy logic also not belong in glazier? That seems to clash with my understanding of the purpose of glazier, so I'm wondering if I can have some insight.

@bzm3r bzm3r added question unpiet Uncoupling piet and glazier labels Oct 18, 2022
@raphlinus
Copy link
Contributor

The presentation logic probably doesn't belong in glazier now, but it should likely be revisited when we tackle how to integrate frame pacing (and window resize, which really isn't a problem any Windows GPU integration designed in the last 5 years even attempts to tackle).

@bzm3r bzm3r closed this as completed Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
unpiet Uncoupling piet and glazier
Projects
None yet
Development

No branches or pull requests

2 participants