Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting minimum window size #632

Closed
cmyr opened this issue Mar 11, 2020 · 5 comments
Closed

allow setting minimum window size #632

cmyr opened this issue Mar 11, 2020 · 5 comments
Labels
D-Easy just needs to be implemented help wanted has no one working on it yet shell/mac concerns the macOS backend

Comments

@cmyr
Copy link
Member

cmyr commented Mar 11, 2020

This will be very similar in implementation to #587.

@cmyr cmyr added help wanted has no one working on it yet shell/mac concerns the macOS backend shell/win concerns the Windows backend shell/gtk concerns the GTK backend D-Easy just needs to be implemented labels Mar 11, 2020
@luleyleo
Copy link
Collaborator

I've implemented it but I'm (again) not sure about naming 😅

The function to set a windows initial size is called WindowDesc::window_size thus is would be consistent to call the function for minimal size window_min_size but it seems odd to me when another function is called WindowDesc::title and not window_title.

Also based on the discussion in #697 it would make most sense to call it with_min_size and with_title.

Thus I would call the function WindowDesc::with_min_size in my PR and then make another one to rename all other methods of WindowDesc to builder style naming

@cmyr
Copy link
Member Author

cmyr commented Mar 18, 2020

yea, naming is a disaster.

something like WindowDesc is only a builder, so I don't feel too bad about not using with everywhere. That's mostly a problem with widgets. I would be happy with either min_size or with_min_size.

@cmyr cmyr removed the shell/gtk concerns the GTK backend label Mar 23, 2020
@cmyr
Copy link
Member Author

cmyr commented Mar 23, 2020

This is now added in druid, but we still need druid-shell support for mac & windows.

@xStrom
Copy link
Member

xStrom commented Mar 23, 2020

This was implemented for Windows by #727. There's also a macOS specific issue for this at #714.

@xStrom xStrom removed the shell/win concerns the Windows backend label Mar 23, 2020
@cmyr
Copy link
Member Author

cmyr commented Mar 23, 2020

okay, lets close in favour of #714

@cmyr cmyr closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Easy just needs to be implemented help wanted has no one working on it yet shell/mac concerns the macOS backend
Projects
None yet
Development

No branches or pull requests

3 participants