Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect formatting-only changes in JVM languages with isFormattingChange #482

Open
tresat opened this issue Apr 12, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@tresat
Copy link

tresat commented Apr 12, 2024

Is your feature request related to a problem? Please describe.
I'd like gitStream to properly detect formatting-only changes (whitespace, indentation fixes, etc.) to JVM language files like Java, Kotlin, Groovy. The check is currently limited to only a few languages as described here https://docs.gitstream.cm/filter-functions/#isformattingchange.

Describe the solution you'd like
isFormattingChange to support JVM languages.

Describe alternatives you've considered
Dropping this automation from our project.

Additional context
Perhaps the minifier used for Android could be used to implement this: https://www.guardsquare.com/proguard?

@tresat tresat added the enhancement New feature or request label Apr 12, 2024
@BenLloydPearson
Copy link
Collaborator

Thanks for the suggestion! This is a great idea and is something that we want to do for a wide range of languages.

However, the challenge is that we have to implement a new engine to check this for each language. We solved Python and JavaScript first because that's what gitStream is built with so we didn't have to make major changes to support them.

I'll update this issue with any further details we have about supporting new languages with isFormattingChange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants